Skip to content

Add CI job for Linux & Mac ARM64 too#1205

Merged
lh3 merged 4 commits intolh3:masterfrom
martin-g:linux-aarch64-ci
Mar 21, 2025
Merged

Add CI job for Linux & Mac ARM64 too#1205
lh3 merged 4 commits intolh3:masterfrom
martin-g:linux-aarch64-ci

Conversation

@martin-g
Copy link
Copy Markdown
Contributor

@martin-g martin-g commented May 8, 2024

No description provided.

@martin-g
Add CI job for Linux ARM64 too
52e9a7a 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Copy Markdown
Contributor Author

martin-g commented May 8, 2024 •
edited
Loading

Currently the build on Linux ARM64 fails with:

 gcc -c -g -Wall -O2 -Wc++-compat  -msse2 -DHAVE_KALLOC  ksw2_ll_sse.c -o ksw2_ll_sse.o
  gcc: error: unrecognized command-line option '-msse2'
  make: *** [Makefile:67: ksw2_ll_sse.o] Error 1
  Error: The process '/home/runner/work/_actions/uraimo/run-on-arch-action/v2/src/run-on-arch.sh' failed with exit code 2

https://github.com/martin-g/minimap2/actions/runs/9001617076/job/24728214278?pr=1

And for Mac ARM64: https://github.com/martin-g/minimap2/actions/runs/9001759602/job/24728641720

Same happens on Bioconda CI:

I am working on a fix!

@martin-g
Add build job for Mac ARM64 too
e8fba8b 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@hasindu2008
Copy link
Copy Markdown
Contributor

hasindu2008 commented May 8, 2024

Are you giving
make arm_neon=1 aarch64=1

martin-g added 2 commits May 8, 2024 15:56
@martin-g
Pass "arm_neon=1 aarch64=1" when building on ARM64
a23f53a 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
change aarch64 to arm64 for the Mac ARM64 check
23620da 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Copy Markdown
Contributor Author

martin-g commented May 8, 2024

Thanks for the hint, @hasindu2008 !
The CI is fully green at my fork - https://github.com/martin-g/minimap2/actions/runs/9002250737

@martin-g martin-g changed the title Add CI job for Linux ARM64 too Add CI job for Linux & Mac ARM64 too May 8, 2024
@lh3 lh3 merged commit a0cbe2e into lh3:master Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martin-g @hasindu2008 @lh3